Add solvers to src code #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @janmirco, Excuse me for the late reply. Thank you for contributing to the project! It is a good idea to move the freshly developed solvers to the sources. I'd drop the As for versioning, please let's discuss it in the corresponding PR and discard these changes here. |
|
Dear @janmirco Regarding the future update of the interface for Newton solvers in I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colleagues of mine and I started using your project to tackle problems in nonlinear solid mechanics. Firstly, thank you for your work! Without your project, I did not see any way of using FEniCSx for my research. This stems from the approach we use for our material models.
Unfortunately, I am not well-versed in the implementations of
dolfinx,ufl.ExternalOperator, andFEMExternalOperator. This commit simply copiessolvers.pyto the source directory and adds necessary imports in__init__.py. I am aware that this might not be the best approach. My intention was to make sure that installingdolfinx-external-operatorenables users to directly use code fromsolvers.py. At least on my end, this works flawlessly.I am using FEniCSx 0.9 with conda. My setup: